This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/5] Refactor bug-strtod.c to better test new types.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 17 May 2016 17:32:09 +0000
- Subject: Re: [PATCH 1/5] Refactor bug-strtod.c to better test new types.
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1463433826 dot git dot murphyp at linux dot vnet dot ibm dot com> <8f35ac2f576ab6b51a7080b05997c92a546100e6 dot 1463433827 dot git dot murphyp at linux dot vnet dot ibm dot com>
On Mon, 16 May 2016, Paul E. Murphy wrote:
> + FTOSTR (fcntstr, sizeof(fstr), "%" FTOSTRM "g", (FTYPE)cnt);\
Missing space in cast, should be "(FTYPE) cnt".
> +#define STRTOD_TEST_FOREACH(mfunc, ...) \
> +({ static int result = 0; \
I don't see any good reason for result to be static here.
--
Joseph S. Myers
joseph@codesourcery.com