This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Remove union wait
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Andreas Schwab <schwab at suse dot de>, "Carlos O'Donell" <carlos at redhat dot com>, libc-alpha at sourceware dot org
- Date: Mon, 11 Apr 2016 14:55:50 -0700 (PDT)
- Subject: Re: [PATCH v2] Remove union wait
- Authentication-results: sourceware.org; auth=none
- References: <56BE07C8 dot 40205 at redhat dot com> <20160307225511 dot 093E92C3BF5 at topped-with-meat dot com> <56DEA20E dot 3040907 at redhat dot com> <56FBBCAF dot 7090806 at redhat dot com> <20160330223228 dot 6A7382C3C54 at topped-with-meat dot com> <56FC5A6C dot 8090408 at redhat dot com> <mvmy48z5dc2 dot fsf at hawking dot suse dot de> <5707AA6C dot 1080800 at redhat dot com> <mvmegacwm33 dot fsf at hawking dot suse dot de> <570BC36A dot 1050603 at redhat dot com>
The substance of the change looks OK to me. (I spent a little while
deciding how much I object to the non-ASCII double-quotes you used in
NEWS. But since there are some non-ASCII characters elsewhere in the
file so I'll restrain my Amerocentric Luddism for now.)
I still don't have much opinion either way about staged deprecation.
Since few others have opined, I think the decision now is up to
whether Carlos changes his mind.
But I will point out that the claim that the deprecation warnings are
just as bad as outright removal is not really right. Packagers or
system-builders or whoever can add -Wno-error=deprecated to the
compilation flags for a particular package via configure, or for an
entire package-building system in that system's configuration for
building all packages (a la redhat-rpm-config), etc. Those are all
things that can be done without patching any sources. When you remove
the feature altogether, there is no way to adjust the build process so
that it continues to work without source code changes.
Thanks,
Roland