This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, Siddhesh Poyarekar <sid at reserved-bit dot com>, libc-alpha at sourceware dot org, Tom Tromey <tom at tromey dot com>, Torvald Riegel <triegel at redhat dot com>, Pedro Alves <palves at redhat dot com>, vapier at gentoo dot org, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>
- Date: Tue, 1 Mar 2016 13:30:59 -0500
- Subject: Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <1447768994-5368-1-git-send-email-martin dot galvan at tallertechnologies dot com> <20160209155450 dot GE1904 at devel dot intra dot reserved-bit dot com> <CAOKbPbYPtn5mMpwGGD-HccXnhNz+eymiJ7Xwe_4WOnesYkw5=A at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602091743430 dot 29757 at digraph dot polyomino dot org dot uk> <CAOKbPba5MGw8XCXRSvapfADD1v_0FoVYhUeJUp01YBXyELLMkg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602101301131 dot 23420 at digraph dot polyomino dot org dot uk> <56BCB9C7 dot 6000100 at redhat dot com> <CAOKbPbZMt+ozv8dPbC8hpZr6yw2d2HcV4OskRP+Pk-i3oYu=nQ at mail dot gmail dot com>
On 03/01/2016 01:24 PM, Martin Galvan wrote:
> As you wish. I may have a couple more questions regarding the
> cross-testing stuff as I dwell on.
>
> However, before I continue: a couple e-mails ago I mentioned the test
> scripts will be based on PExpect (which has a GPL-compatible license).
> I want to confirm again this is acceptable before I keep working on
> this. If necessary I could add some code to check if PExpect is
> present before trying to run the tests.
I don't see any problem with using or requiring that PExpect be installed
on the development system to run these tests. It should be possible to
mark the tests as UNSUPPORTED if pexpect is not present (which can be
done dynamically by exiting with the reserved error code 77 IIRC).
Cheers,
Carlos.