This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] posix: execvpe cleanup



On 29-02-2016 16:10, Paul Eggert wrote:
> On 02/29/2016 10:33 AM, Adhemerval Zanella wrote:
>> +      if ((argc+1) == INT_MAX)
> 
> This is clearer as:
> 
>    if (argc == INT_MAX - 1)
> 
> Spaces around binary "+" and/or "-", please, and avoid redundant parens.

I will change it.
> 
> To some extent I've reviewed the code so often that I'm burned out as a reviewer, but it looks OK to me other than these minor glitches.

Thank you for your very thoroughly review. 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]