This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later


"Carlos O'Donell" <carlos@redhat.com> writes:

> diff --git a/math/test-math-isinff.cc b/math/test-math-isinff.cc
> new file mode 100644
> index 0000000..195d753
> --- /dev/null
> +++ b/math/test-math-isinff.cc
> @@ -0,0 +1,48 @@
> +/* Test for bug 19439.
> +   Copyright (C) 2016 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <http://www.gnu.org/licenses/>.  */
> +
> +#define _GNU_SOURCE 1
> +#include <math.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +
> +static int
> +do_test (void)
> +{
> +  /* Verify that isinff, isinfl, isnanf, and isnanlf are defined
> +     in the header under C++11 and can be called.  Without the
> +     header fix this test will not compile.  */
> +  if (isinff (1.0f)
> +      || !isinff (INFINITY)
> +      || isinfl (1.0L)
> +      || !isinfl (INFINITY)
> +      || isnanf (2.0f)
> +      || !isnanf (NAN)
> +      || isnanl (2.0L)
> +      || !isnanl (NAN))

That doesn't compile on platforms where long == long double, since they
do not declare any *l functions (arm, hppa, mips/o32).

test-math-isinff.cc: In function 'int do_test()':
test-math-isinff.cc:33:22: error: 'isinfl' was not declared in this scope
       || isinfl (1.0L)
                      ^
test-math-isinff.cc:37:22: error: 'isnanl' was not declared in this scope
       || isnanl (2.0L)
                      ^

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]