This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] BZ #19590: Fixed build of shared objects that use functions

2016-02-11 19:43 GMT+03:00 Joseph Myers <>:
> On Thu, 11 Feb 2016, Andrew Senkevich wrote:
>> If we need runtime tests with calls to finite aliases it looks better
>> to adopt build of existing libmvec tests. We can call finite aliases
>> in *-wrappers.c and build shared library from them and link with it
>> test binaries. Is this approach looks OK?
> I don't think the finite aliases should be considered part of the API to
> test; it's an implementation detail of the header that they may get
> referenced in certain circumstances.

I agree.

>  The relevant thing to test is
> whether building a program that directly calls the scalar functions, with
> options such that the calls get vectorized, works (including with variant
> options for e.g. LTO).

But it looks more like compiler test, not library. Or do you mean some
ABI test for vector functions?
In any case is it necessary for this patch or the following patch is
Ok for thrunk?

diff --git a/ChangeLog b/ChangeLog
index 11c3156..6ebcefb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2016-02-10  Andrew Senkevich  <>
+           Carlos O'Donell  <>
+       [BZ #19590]
+       * sysdeps/x86_64/fpu/svml_finite_alias.S (ALIAS_IMPL): Use PLT.
 2016-02-04  Rajalakshmi Srinivasaraghavan  <>

        * sysdeps/powerpc/fpu/libm-test-ulps: Regenerated.
diff --git a/sysdeps/x86_64/fpu/svml_finite_alias.S
index 0062fe4..8314cf4 100644
--- a/sysdeps/x86_64/fpu/svml_finite_alias.S
+++ b/sysdeps/x86_64/fpu/svml_finite_alias.S
@@ -23,8 +23,7 @@

 #define ALIAS_IMPL(alias, target) \
 ENTRY (alias); \
-       call target; \
-       ret; \
+       jmp target@PLT; \
 END (alias)



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]