This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix nptl/tst-setuid3.c
- From: Florian Weimer <fweimer at redhat dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>
- Date: Tue, 19 Jan 2016 21:33:56 +0100
- Subject: Re: [PATCH] Fix nptl/tst-setuid3.c
- Authentication-results: sourceware.org; auth=none
- References: <569E97E2 dot 1000307 at linux dot vnet dot ibm dot com> <569E99CF dot 3020504 at redhat dot com> <569E9AA0 dot 3070208 at linaro dot org> <569E9D4A dot 8050108 at linux dot vnet dot ibm dot com>
On 01/19/2016 09:32 PM, Paul E. Murphy wrote:
> +/* True if pthread_barrier_wait returns without an error. */
> +static inline bool
> +is_invalid_barrier_ret (int x)
> +{
> + return x != 0 && x != PTHREAD_BARRIER_SERIAL_THREAD;
> +}
Sorry, just realized that the comment is wrong, should be “returned
*with* an error”. :-/
Otherwise, still okay from my point of view.
Florian