This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Use ENTRY/END in sysdeps/x86_64/nptl/pthread_spin*.S
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>, GLIBC Devel <libc-alpha at sourceware dot org>
- Cc: Wei Mi <wmi at google dot com>
- Date: Mon, 18 Jan 2016 17:18:59 -0500
- Subject: Re: [patch] Use ENTRY/END in sysdeps/x86_64/nptl/pthread_spin*.S
- Authentication-results: sourceware.org; auth=none
- References: <CALoOobPfYEt0R4LJo3cGZEP-JA5YFAT11sSSzLqsFamkXcdYNg at mail dot gmail dot com>
On 01/18/2016 04:11 PM, Paul Pluzhnikov wrote:
> Greetings,
>
> Currently, x86_64 pthread_spin_{lock,unlock,trylock} lack unwind
> descriptors, which causes tools like GDB and libunwind to guess how to
> unwind from them. Libunwind happens to guess incorrectly, leading to
> either bad stack trace, or a crash.
>
> Attached patch fixes this. Tested on Linux/x86_64. Ok for trunk?
>
> P.S. I'd like to excise other instances of functions that lack unwind
> descriptors in a follow-up patch, if that's ok.
>
> 2016-01-18 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * sysdeps/x86_64/nptl/pthread_spin_lock.S (pthread_spin_lock):
> Use ENTRY/END
> * sysdeps/x86_64/nptl/pthread_spin_trylock.S
> (pthread_spin_trylock): Likewise
> * sysdeps/x86_64/nptl/pthread_spin_unlock.S
> (pthread_spin_unlock): Likewise
>
Modulo your broken mail client wrapping the Changelog this looks good to me.
It needs a public bug though.
Cheers,
Carlos.