This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add __private_ss to s390 struct tcbhead.

From: Marcin KoÅcielnicki <koriakin at 0x04 dot net>
To: Andreas Schwab <schwab at suse dot de>
Cc: libc-alpha at sourceware dot org
Date: Wed, 13 Jan 2016 11:05:50 +0100
Subject: Re: [PATCH] Add __private_ss to s390 struct tcbhead.
Authentication-results: sourceware.org; auth=none
References: <1451752466-9429-1-git-send-email-koriakin at 0x04 dot net> <mvmy4btvozg dot fsf at hawking dot suse dot de>

On 13/01/16 09:54, Andreas Schwab wrote:

Marcin KoÅcielnicki <koriakin@0x04.net> writes:

diff --git a/sysdeps/s390/nptl/tls.h b/sysdeps/s390/nptl/tls.h
index 28a2119..0e61154 100644
--- a/sysdeps/s390/nptl/tls.h
+++ b/sysdeps/s390/nptl/tls.h
@@ -53,7 +53,11 @@ typedef struct
    int gscope_flag;
  #ifndef __ASSUME_PRIVATE_FUTEX
    int private_futex;
+#else
+  int __glibc_reserved1;
  #endif


You can keep the name the same in all cases.  This is an internal
header, so no namespace control.

+  /* GCC split stack support.  */
+  void *__private_ss;


Similarily, no need for namespace control.

Andreas.

I've named both consistently with x86. While it doesn't matter for__glibc_reserved1, it'd be better to keep __private_ss called the sameon all platforms (even if we never use it in glibc itself).


Marcin KoÅcielnicki

References:
- [PATCH] Add __private_ss to s390 struct tcbhead.
  - From: Marcin KoÅcielnicki
- Re: [PATCH] Add __private_ss to s390 struct tcbhead.
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]