This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH V2] Ensure -fpmath != sse when SSE is disabled [BZ #17950]
- From: Khem Raj <raj dot khem at gmail dot com>
- To: libc-alpha at sourceware dot org
- Cc: Khem Raj <raj dot khem at gmail dot com>
- Date: Wed, 13 Jan 2016 01:48:55 +0000
- Subject: [PATCH V2] Ensure -fpmath != sse when SSE is disabled [BZ #17950]
- Authentication-results: sourceware.org; auth=none
This fixes errors when we inject sse options through CFLAGS and now
that we have -Werror turned on by default this warning turns to become
error on x86
gcc -m32 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -x c /dev/null -S
-mno-sse -mno-mmx
generates warning
/dev/null:1:0: warning: SSE instruction set disabled, using 387
arithmetics
where as
gcc -m32 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -x c /dev/null -S
-mno-sse -mno-mmx -mfpmath=387
Generates no warnings
---
Changes since v1:
- Add BZ enry to ChangeLog and commit message
ChangeLog | 6 ++++++
sysdeps/i386/Makefile | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index 600c3dd..a44f877 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2016-01-12 Khem Raj <raj.khem@gmail.com>
+
+ [BZ #17950]
+ * sysdeps/i386/Makefile [$(subdir) == elf] (CFLAGS-.os):
+ Add -mfpmath=387.
+
2016-01-11 Andreas Schwab <schwab@suse.de>
[BZ #19253]
diff --git a/sysdeps/i386/Makefile b/sysdeps/i386/Makefile
index 168512f..70153b3 100644
--- a/sysdeps/i386/Makefile
+++ b/sysdeps/i386/Makefile
@@ -89,7 +89,7 @@ ifeq ($(subdir),elf)
# the first 3 mm/xmm/ymm/zmm registers are used to pass vector parameters
# which must be preserved.
CFLAGS-.os += $(if $(filter $(@F),$(patsubst %,%.os,$(all-rtld-routines))),\
- -mno-sse -mno-mmx)
+ -mno-sse -mno-mmx -mfpmath=387)
tests-special += $(objpfx)tst-ld-sse-use.out
$(objpfx)tst-ld-sse-use.out: ../sysdeps/i386/tst-ld-sse-use.sh $(objpfx)ld.so
--
2.7.0