This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] argp: Use fwrite_unlocked instead of __fxprintf when !_LIBC
- From: Khem Raj <raj dot khem at gmail dot com>
- To: Khem Raj <raj dot khem at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 4 Jan 2016 11:08:34 -0800
- Subject: Re: [PATCH] argp: Use fwrite_unlocked instead of __fxprintf when !_LIBC
- Authentication-results: sourceware.org; auth=none
- References: <1451679626-28351-1-git-send-email-raj dot khem at gmail dot com> <20160102032137 dot GL25803 at vapier dot lan>
On Fri, Jan 1, 2016 at 7:21 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On 01 Jan 2016 20:20, Khem Raj wrote:
>> __fxprintf is not available when argp is built outside libc
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> ChangeLog | 5 +++++
>> argp/argp-fmtstream.c | 4 ++++
>
> i forget where we document these things, but usually modules that utilize
> _LIBC are kept in sync with other projects, and we often like to see such
> changes sent/merged simultaneously with them. this one looks like gnulib.
gnulib already have a check for it introduced via this commit
http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=c72047a1ed44c8c9509f1593d726ccd63ceb965c
it checks for USE_IN_LIBIO
> -mike