This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Eliminate redundant sign extensions in pow()
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: Anton Blanchard <anton at samba dot org>
- Cc: Joseph Myers <joseph at codesourcery dot com>, <cseo at linux dot vnet dot ibm dot com>, <sjmunroe at us dot ibm dot com>, <libc-alpha at sourceware dot org>
- Cc:
- Date: Mon, 04 Jan 2016 14:57:56 -0200
- Subject: Re: [PATCH] Eliminate redundant sign extensions in pow()
- Authentication-results: sourceware.org; auth=none
- References: <20151116214413 dot 26babb5f at kryten> <alpine dot DEB dot 2 dot 10 dot 1511161056170 dot 25844 at digraph dot polyomino dot org dot uk> <20151120233700 dot 48b054da at kryten>
Anton Blanchard <anton@samba.org> writes:
>> OK with a ChangeLog entry if you've done the usual testing with the
>> testsuite without any new ulps for pow appearing (you didn't say).
>
> Thanks Joseph.
>
> --
>
> When looking at the code generated for pow() on ppc64 I noticed quite
> a few sign extensions. Making the array indices unsigned reduces the
> number of sign extensions from 24 to 7.
>
> Tested for powerpc64le and x86_64.
>
> 2015-11-20 Anton Blanchard <anton@samba.org>
>
> * sysdeps/ieee754/dbl-64/e_pow.c (log1): Use unsigned int
> for array indices.
> * sysdeps/ieee754/dbl-64/e_pow.c (my_log2): Likewise.
LGTM too.
I just pushed it as 0a1f1e78.
Thanks!
--
Tulio Magno