This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 PING] Rely on the shell's built-in 'pwd' command.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Ludovic CourtÃs <ludo at gnu dot org>
- Cc: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Thu, 3 Dec 2015 00:00:20 -0500
- Subject: Re: [PATCH v2 PING] Rely on the shell's built-in 'pwd' command.
- Authentication-results: sourceware.org; auth=none
- References: <87610xisjp dot fsf at gnu dot org> <alpine dot DEB dot 2 dot 10 dot 1511192146570 dot 6968 at digraph dot polyomino dot org dot uk> <87poz5j83g dot fsf at gnu dot org> <alpine dot DEB dot 2 dot 10 dot 1511201146140 dot 24094 at digraph dot polyomino dot org dot uk> <87mvu7d7as dot fsf_-_ at gnu dot org> <87vb8lnl47 dot fsf_-_ at gnu dot org> <565DC88E dot 9050208 at redhat dot com> <87oae94zgu dot fsf at gnu dot org>
On 12/01/2015 04:43 PM, Ludovic CourtÃs wrote:
> "Carlos O'Donell" <carlos@redhat.com> skribis:
>
>> On 11/29/2015 05:41 AM, Ludovic CourtÃs wrote:
>>> Ping. :-)
>>>
>>> https://sourceware.org/ml/libc-alpha/2015-11/msg00516.html
>>>
>>> TIA,
>>> Ludoâ.
>>>
>>> ChangeLog:
>>>
>>> 2015-11-21 Ludovic CourtÃs <ludo@gnu.org>
>>>
>>> * configure.ac: Use 'pwd -P' instead of '/bin/pwd'.
>>> * configure: Regenerate.
>>> * io/ftwtest-sh: Use 'pwd -P' instead of '/bin/pwd'.
>>> * scripts/rellns-sh: Likewise. Remove 'pwd' variable.
>>
>> This looks good to me.
>>
>> POSIX pwd contains `-P` and that's the key for portability.
>
> Thanks for the review.
>
> I donât have commit access so Iâd be grateful if one of you could commit it.
Tested on x86_64 and pushed.
Cheers,
Carlos.