This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- From: Tom Tromey <tom at tromey dot com>
- To: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- Cc: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org, Tom Tromey <tom at tromey dot com>, "Carlos O'Donell" <carlos at redhat dot com>, Torvald Riegel <triegel at redhat dot com>, Pedro Alves <palves at redhat dot com>, vapier at gentoo dot org, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>
- Date: Tue, 17 Nov 2015 10:34:15 -0700
- Subject: Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <1447768994-5368-1-git-send-email-martin dot galvan at tallertechnologies dot com> <564B4DE4 dot 7010306 at redhat dot com> <CAOKbPbYus7ci-zY0PMCFQ6rx1a3LUv=N=aJBXYV1bsWXwLGXzA at mail dot gmail dot com>
Martin> When developing these printers I based my work on the ones for
Martin> libstdc++. I think those don't come with unit tests either.
They do. They work by invoking gdb and checking the expected output.
>> I'm worried that these helpers break the debugging experience at some
>> point, and we would like to catch that early.
FWIW it is a valid concern, this has happened with the libstdc++ printers.
Martin> libstdc++ does this as well: I had to add a
Martin> bit of code to my .gdbinit so that those printers will always load
Martin> them at startup.
With a correct setup (typically done by the distros), you shouldn't need
this. That's what all the hook business is for. (I didn't read your
patch, sorry; but you should do this if you haven't already.)
Tom