This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Remove miscellaneous GCC >= 4.7 version conditionals
- From: Florian Weimer <fweimer at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 4 Nov 2015 20:39:27 +0100
- Subject: Re: Remove miscellaneous GCC >= 4.7 version conditionals
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1510281744400 dot 14980 at digraph dot polyomino dot org dot uk>
On 10/28/2015 06:45 PM, Joseph Myers wrote:
> -#elif defined __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4
> -/* Atomic compare and exchange. */
> -# define __arch_compare_and_exchange_val_32_acq(mem, newval, oldval) \
> - __sync_val_compare_and_swap ((mem), (oldval), (newval))
> #else
> # define __arch_compare_and_exchange_val_32_acq(mem, newval, oldval) \
> __arm_assisted_compare_and_exchange_val_32_acq ((mem), (newval), (oldval))
> #endif
>
> -#if !__GNUC_PREREQ (4, 7) || !defined (__GCC_HAVE_SYNC_COMPARE_AND_SWAP_4)
> +#ifndef __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4
Can you merge the #ifndef into the preceding #else block? I think this
was done this way to avoid duplication, but it's not necessary anymore.
The x86 bits look okay.
Florian