This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 05/13] nptl: powerpc64: Fix Race conditions in pthread cancellation (BZ#12683)
- From: Steven Munroe <munroesj at linux dot vnet dot ibm dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 09 Oct 2015 10:04:11 -0500
- Subject: Re: [PATCH 05/13] nptl: powerpc64: Fix Race conditions in pthread cancellation (BZ#12683)
- Authentication-results: sourceware.org; auth=none
- References: <1444234995-9542-1-git-send-email-adhemerval dot zanella at linaro dot com> <1444234995-9542-6-git-send-email-adhemerval dot zanella at linaro dot com>
- Reply-to: munroesj at linux dot vnet dot ibm dot com
On Wed, 2015-10-07 at 13:23 -0300, Adhemerval Zanella wrote:
> From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> This patches adds the powerpc64 modification required for the BZ#12683 fix.
> It basically removes the enable_asynccancel/disable_asynccancel function
> usage on code used on powerpc64, and provide a arch-specific symbol that
> contains global markers to be used in SIGCANCEL handler.
>
> Checked on powerpc64 and powerpc64le.
>
> * sysdeps/unix/sysv/linux/powerpc/powerpc64/fcntl.c (__libc_fnctl):
> Remove CANCEL_ASYNC/CANCEL_RESET usage.
> * sysdeps/unix/sysv/linux/powerpc/powerpc64/sysdep-cancel.h (PSEUDO):
> Likewise.
> (PSEUDO_RET): Likewise.
> (__pthread_get_ip): Add implementation.
> * sysdeps/unix/sysv/linux/powerpc/powerpc64/sysdep.h
> (SYSCALL_CANCEL_ERROR): New define.
> (SYSCALL_CANCEL_ERRNO): New define.
> * sysdeps/unix/sysv/linux/powerpc/syscall_cancel.S: New file:
> cancellable syscall.
> * sysdeps/unix/sysv/linux/powerpc/sysdep.c (__syscall_cancel_error):
> New symbol: cancellable syscall error handler.
> ---
LGTM