This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #18441] add testcase from bugreport
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>, Leonhard Holz <leonhard dot holz at web dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 7 Oct 2015 12:17:58 -0400
- Subject: Re: [PATCH][BZ #18441] add testcase from bugreport
- Authentication-results: sourceware.org; auth=none
- References: <558E8EB4 dot 3070407 at web dot de> <20150701222707 dot GA20947 at domone>
On 07/01/2015 06:27 PM, OndÅej BÃlka wrote:
> On Sat, Jun 27, 2015 at 01:53:24PM +0200, Leonhard Holz wrote:
>> This patch adds the testcase mentioned in the bug report to the strcoll benchmark.
>> A patch that solves the problem follows.
>>
>>
>> * benchtests/bench-strcoll.c: Add thai text with en_US.UTF-8 locale.
>> * benchtests/strcoll-inputs/wikipedia-th#en_US.UTF-8: New file.
>>
> This is ok as patch but testcase tooks a minute. I would wait with
> commiting this until bug is fixed.
The benchmarks may take a long time to run, and therefore I see no reason
not to check this in immediately. A minute is not too long to wait for the
benchmarks.
Please check this in.
Cheers,
Carlos.