This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Clean up state on patchwork
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: Siddhesh Poyarekar <sid at reserved-bit dot com>, <libc-alpha at sourceware dot org>, Florian Weimer <fweimer at redhat dot com>
- Date: Mon, 28 Sep 2015 17:16:10 +0000
- Subject: Re: Clean up state on patchwork
- Authentication-results: sourceware.org; auth=none
- References: <1442410615 dot 2348 dot 19 dot camel at reserved-bit dot com> <alpine dot DEB dot 2 dot 10 dot 1509172302350 dot 2455 at digraph dot polyomino dot org dot uk> <alpine dot DEB dot 2 dot 10 dot 1509252025170 dot 1123 at digraph dot polyomino dot org dot uk> <20150925205526 dot GA1535 at vapier dot lan> <56094872 dot 80102 at redhat dot com> <20150928153301 dot GL5140 at vapier dot lan> <alpine dot DEB dot 2 dot 10 dot 1509281545320 dot 31579 at digraph dot polyomino dot org dot uk> <20150928162143 dot GM5140 at vapier dot lan> <560973F9 dot 40303 at redhat dot com>
On Mon, 28 Sep 2015, Carlos O'Donell wrote:
> Isn't it simply easier to add a "Resubmit" state, mark it as "not needing action"
> (so it doesn't show up on the normal lists) and go from there?
It would be wrong to put a patch in such a state without explicitly
informing the person concerned that it's been put in such a state (and
wrong to do so at all for infrequent contributors, where we should be
helping them along rather than adding hoops for them to jump). I'm not
actually convinced there should be such a state at all; if on review you
think the patch is no longer applicable to current sources that's Changes
Requested, if it applies but you want retesting you can say e.g. "OK if it
still applies cleanly and tests OK" (that's Accepted, moving to Changes
Requested if it doesn't still work).
--
Joseph S. Myers
joseph@codesourcery.com