This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Update on commit and release workflow discussions
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>, <libc-alpha at sourceware dot org>, <carlos at redhat dot com>
- Date: Tue, 8 Sep 2015 22:19:31 +0000
- Subject: Re: Update on commit and release workflow discussions
- Authentication-results: sourceware.org; auth=none
- References: <20150817115747 dot GC2415 at spoyarek dot pnq dot redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1508171441030 dot 29836 at digraph dot polyomino dot org dot uk> <20150817171102 dot GD2415 at spoyarek dot pnq dot redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1508171720590 dot 29836 at digraph dot polyomino dot org dot uk> <20150817193536 dot GE2415 at spoyarek dot pnq dot redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1508171940480 dot 24954 at digraph dot polyomino dot org dot uk> <20150821021905 dot GQ2415 at spoyarek dot pnq dot redhat dot com> <20150908214913 dot A797C2C39FE at topped-with-meat dot com>
On Tue, 8 Sep 2015, Roland McGrath wrote:
> > I vaguely remember someone (Roland?) not being in favour of generating
> > the ChangeLog at any time except during release. I am inclined
> > towards generating ChangeLogs to fix them up because it does not
> > involve yet another layer of metadata.
>
> I don't really understand the second sentence.
* If you want to fix something in the generated ChangeLog, generate it,
check it in, make the change to the checked-in file.
As opposed to:
* Don't check in any more ChangeLog changes; rather, maintain an
on-the-side list of amendments applied to the ChangeLog when it's
generated at release time.
> My position on this is simply that amending logs is not worthwhile enough
> to merit any nontrivial complications to the machinery or workflow. I'd
> rather start with a system that is as simple as possible, and only worry
> about log amendments if and when we have a concrete occasion of someone
> feeling very strongly that a particular log entry needs amending.
I suspect that at the start we'll get lots of commits where people
completely forget the markup for ChangeLog generation and some amendment
is needed to get a ChangeLog entry for those changes at all. (We might
want a hook to reject pushes to master and release branches that don't
have either the markup for a ChangeLog entry or for one being explicitly
and deliberately absent, to avoid this issue.)
> 4. Remove existing list from top of trunk NEWS file.
Which involves making sure all the bugs in the list have the right
metadata in Bugzilla (and then watching in future when people close bugs
as fixed to make sure they put in the right metadata).
--
Joseph S. Myers
joseph@codesourcery.com