This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2 1/2] nptl: Add adapt_count parameter to lll_unlock_elision
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- Cc: "libc-alpha\ at sourceware dot org" <libc-alpha at sourceware dot org>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Date: Thu, 03 Sep 2015 18:47:07 +0200
- Subject: Re: [PATCHv2 1/2] nptl: Add adapt_count parameter to lll_unlock_elision
- Authentication-results: sourceware.org; auth=none
- References: <55E86D63 dot 9010304 at linux dot vnet dot ibm dot com>
"Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
> #ifndef lll_unlock_elision
> -#define lll_unlock_elision(a,b) ({ lll_unlock (a,b); 0; })
> +#define lll_unlock_elision(a,b,c) ({ lll_unlock (a,b); 0; })
> #endif
>
> static int
> @@ -63,7 +63,7 @@ __pthread_mutex_unlock_usercnt (mutex, decr)
> else if (__glibc_likely (type == PTHREAD_MUTEX_TIMED_ELISION_NP))
> {
> /* Don't reset the owner/users fields for elision. */
> - return lll_unlock_elision (mutex->__data.__lock,
> + return lll_unlock_elision (mutex->__data.__lock, mutex->__data.__elision,
> PTHREAD_MUTEX_PSHARED (mutex));
That doesn't fit together.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."