This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Don't use -Wno-uninitialized in math/
- From: Chris Metcalf <cmetcalf at ezchip dot com>
- To: <sellcey at imgtec dot com>, Joseph Myers <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 26 Aug 2015 15:57:11 -0400
- Subject: Re: Don't use -Wno-uninitialized in math/
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp dot mailfrom=cmetcalf at ezchip dot com;
- References: <alpine dot DEB dot 2 dot 10 dot 1508201800380 dot 30940 at digraph dot polyomino dot org dot uk> <1440173079 dot 23512 dot 36 dot camel at ubuntu-sellcey>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:23
On 08/21/2015 12:04 PM, Steve Ellcey wrote:
On Thu, 2015-08-20 at 18:00 +0000, Joseph Myers wrote:
The uninitialized variable warnings in math/ having been fixed for all
the supported floating-point formats, this patch removes the use of
-Wno-uninitialized there, continuing with the goal of avoiding -Wno-
options in makefiles as far as possible..
Tested for x86_64 and x86 (full build and testsuite runs), and for
powerpc and mips64 (verified that glibc builds without errors).
Committed.
I am seeing a mips32 build failure (using Top-of-tree GCC) with this
change:
In file included from ../soft-fp/soft-fp.h:321:0,
from ../soft-fp/fmatf4.c:30,
from ../sysdeps/mips/ieee754/s_fmal.c:7:
../soft-fp/fmatf4.c: In function ï~@~X__fmalï~@~Y:
../soft-fp/op-common.h:281:10: error: ï~@~XR_eï~@~Y may be used uninitialized in this function [-Werror=maybe-uninitialized]
X##_e++; \
^
../soft-fp/fmatf4.c:40:14: note: ï~@~XR_eï~@~Y was declared here
FP_DECL_Q (R);
^
../soft-fp/op-common.h:38:14: note: in definition of macro ï~@~X_FP_DECLï~@~Y
_FP_I_TYPE X##_e __attribute__ ((unused)) _FP_ZERO_INIT; \
^
../soft-fp/fmatf4.c:40:3: note: in expansion of macro ï~@~XFP_DECL_Qï~@~Y
FP_DECL_Q (R);
Doing a tilegx build just now against the tip, I see something similar,
using gcc 4.8.2:
In file included from ../soft-fp/soft-fp.h:321:0,
from ../soft-fp/fmadf4.c:30,
from ../sysdeps/tile/s_fma.c:1:
../soft-fp/fmadf4.c: In function â__fmaâ:
../soft-fp/op-common.h:274:10: error: âR_eâ may be used uninitialized in this function [-Werror=maybe-uninitialized]
X##_e += _FP_EXPBIAS_##fs; \
^
../soft-fp/fmadf4.c:40:14: note: âR_eâ was declared here
FP_DECL_D (R);
^
../soft-fp/op-common.h:38:14: note: in definition of macro â_FP_DECLâ
_FP_I_TYPE X##_e __attribute__ ((unused)) _FP_ZERO_INIT; \
^
../soft-fp/fmadf4.c:40:3: note: in expansion of macro âFP_DECL_Dâ
FP_DECL_D (R);
^
--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com