This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] Replace BZERO_P/PIC with USE_AS_BZERO/SHARED


On Wed, Aug 26, 2015 at 06:43:31AM -0700, H.J. Lu wrote:
> Replace BZERO_P with USE_AS_BZERO in i586/i686 memset.S to support i386
> multi-arch memset.  Also we should check SHARED not PIC for libc.so
> since libc.a may be compiled with PIC.
> 
> OK for master?
> 
This is ok as patch.

However as I noted in x64 memset this is ineffective as it doubles code
size for mostly identical code. So as followup one needs to create bzero
stub that jumps into memset. Should I do it?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]