This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH COMMITTED] nptl: Document crash due to incorrect use of locks
- From: Florian Weimer <fweimer at redhat dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 20 Aug 2015 08:46:01 +0200
- Subject: [PATCH COMMITTED] nptl: Document crash due to incorrect use of locks
- Authentication-results: sourceware.org; auth=none
--
Florian Weimer / Red Hat Product Security
>From cd4e69ed3e4b2d51ebd3dfaa0730793cf913de77 Mon Sep 17 00:00:00 2001
Message-Id: <cd4e69ed3e4b2d51ebd3dfaa0730793cf913de77.1440053096.git.fweimer@redhat.com>
From: Florian Weimer <fweimer@redhat.com>
Date: Thu, 20 Aug 2015 08:44:09 +0200
Subject: [PATCH] nptl: Document crash due to incorrect use of locks
To: libc-alpha@sourceware.org
---
ChangeLog | 5 +++++
sysdeps/x86/elide.h | 4 +++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index b3c9892..c0f7f5d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2015-08-20 Florian Weimer <fweimer@redhat.com>
+
+ * sysdeps/x86/elide.h (ELIDE_UNLOCK): Document crash due to
+ incorrect use.
+
2015-08-19 Joseph Myers <joseph@codesourcery.com>
[BZ #18370]
diff --git a/sysdeps/x86/elide.h b/sysdeps/x86/elide.h
index 47e89cf..6e53288 100644
--- a/sysdeps/x86/elide.h
+++ b/sysdeps/x86/elide.h
@@ -93,7 +93,9 @@ elision_adapt(signed char *adapt_count, unsigned int status)
ret; \
})
-/* Returns true if lock defined by IS_LOCK_FREE was elided. */
+/* Returns true if lock defined by IS_LOCK_FREE was elided. The call
+ to _xend crashes if the application incorrectly tries to unlock a
+ lock which has not been locked. */
#define ELIDE_UNLOCK(is_lock_free) \
({ \
--
2.4.3