This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix BZ #18660 -- overflow in getusershell
- From: Zack Weinberg <zackw at panix dot com>
- To: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Wed, 19 Aug 2015 12:28:42 -0400
- Subject: Re: [patch] Fix BZ #18660 -- overflow in getusershell
- Authentication-results: sourceware.org; auth=none
- References: <CAPC3xaqdOk4EWQJEiBLidfVxSx1iH5F9k_DTZDamkjQR1xZ3Gw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1508171058110 dot 9234 at digraph dot polyomino dot org dot uk> <CAPC3xaqRbCc1Ytd7AAkmEjgr_wtq_AA-hEvRPZiup2QwHMdS-w at mail dot gmail dot com> <20150819145531 dot GE1584 at vapier> <mvm8u97cn9n dot fsf at hawking dot suse dot de> <20150819161914 dot GG1584 at vapier>
On Wed, Aug 19, 2015 at 12:19 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On 19 Aug 2015 17:26, Andreas Schwab wrote:
>> Mike Frysinger <vapier@gentoo.org> writes:
>> > how can we justify this ugly code in the name of speed ?
>>
>> This ugly code was lifted directly from BSD ...
>
> i'm aware of its history. that doesn't justify us keeping the ugly code,
> just the API.
FWIW I concur with Mike.
zw