This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/5] [v2] Add C11 threads.h support.


On Tue, 11 Aug 2015, Juan Manuel Torres Palma wrote:

> -linknamespace-libs-isoc = $(common-objpfx)libc.a $(common-objpfx)math/libm.a
> +linknamespace-libs-isoc = $(common-objpfx)libc.a $(common-objpfx)math/libm.a 

This change is just adding spurious trailing whitespace.

> diff --git a/conform/data/threads.h-data b/conform/data/threads.h-data
> new file mode 100644
> index 0000000..bbd810f
> --- /dev/null
> +++ b/conform/data/threads.h-data
> @@ -0,0 +1,56 @@

> +allow-header time.h

Inclusion of time.h from threads.h isn't simply allowed - it's *required*.  
So you should have

#include "time.h-data"

instead, to require all the C11 definitions from time.h to appear when 
threads.h is included.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]