This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: glibc 2.22 -- Final testing for 32-bit x86 failing?
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: "Carlos O'Donell" <carlos at redhat dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 6 Aug 2015 00:55:21 -0700 (PDT)
- Subject: Re: glibc 2.22 -- Final testing for 32-bit x86 failing?
- Authentication-results: sourceware.org; auth=none
- References: <55BD1D92 dot 6040406 at redhat dot com> <CAMe9rOr3fOZK_PUt-pEqivGi2h3qmSaQaKLipN7LG8VgB45D7A at mail dot gmail dot com> <CALoOobPwKv003N5BMcPQ+QThRkfpk9s5Ev86srZa+JuCSvf6DA at mail dot gmail dot com> <55C1B80F dot 8040702 at redhat dot com> <CALoOobMTOdarsipDDNKFxeg4DLqyEqM+CPvsOBxhsphYwy81JQ at mail dot gmail dot com>
> Hmm, for some reason I can't reproduce this anymore, and unistd.h is
> already included indirectly.
>
> I don't understand why that's happening. But it still seems like a
> good idea from header hygiene perspective.
It is definitely correct (and in the "obvious" category) to have each
source file explicitly #include the header that is the canonical declarator
of each symbol that source file uses directly.