This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: glibc 2.22 -- Final testing for 32-bit x86 failing?
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 05 Aug 2015 03:15:27 -0400
- Subject: Re: glibc 2.22 -- Final testing for 32-bit x86 failing?
- Authentication-results: sourceware.org; auth=none
- References: <55BD1D92 dot 6040406 at redhat dot com> <CAMe9rOr3fOZK_PUt-pEqivGi2h3qmSaQaKLipN7LG8VgB45D7A at mail dot gmail dot com> <CALoOobPwKv003N5BMcPQ+QThRkfpk9s5Ev86srZa+JuCSvf6DA at mail dot gmail dot com>
On 08/01/2015 06:27 PM, Paul Pluzhnikov wrote:
> The following trivial patch fixes this:
LGTM for 2.23, which is now open. Falls under the obvious category
for including a header for a function you use.
c.
> diff --git a/libio/oldfileops.c b/libio/oldfileops.c
> index 54789b2..25797c8 100644
> --- a/libio/oldfileops.c
> +++ b/libio/oldfileops.c
> @@ -41,6 +41,7 @@
> #include <string.h>
> #include <errno.h>
> #include <stdlib.h>
> +#include <unistd.h>
> #ifndef errno
> extern int errno;
> #endif
>
> Ok to commit above?
>
> After that, make check:
>
> XPASS: conform/ISO11/complex.h/conform
> XPASS: conform/ISO11/stdalign.h/conform
> XPASS: conform/ISO11/stdnoreturn.h/conform
> FAIL: elf/tst-protected1a
> FAIL: elf/tst-protected1b
>
> As far as I understand, the tst-protected1{a,b} are expected to fail
> with binutils 2.24-5ubuntu13
>
>