This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use "|" instead of "+" when combine the _IO_LINE_BUF and _IO_UNBUFFERED flags
- From: Andreas Schwab <schwab at suse dot de>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: Feng Gao <gfree dot wind at gmail dot com>, Siddhesh Poyarekar <siddhesh at redhat dot com>, libc-alpha at sourceware dot org
- Date: Wed, 08 Jul 2015 11:46:20 +0200
- Subject: Re: [PATCH] Use "|" instead of "+" when combine the _IO_LINE_BUF and _IO_UNBUFFERED flags
- Authentication-results: sourceware.org; auth=none
- References: <CA+6hz4qE5L-6LQEvVawdKtXXrqpP-c-VO1SmGtamRJUoRWYLRQ at mail dot gmail dot com> <20150707073145 dot GK13549 at spoyarek dot pnq dot redhat dot com> <CA+6hz4r4FjfTN5+AfM=x7_2xCC-3_FMeniMHdYNufBRrd4g8Lg at mail dot gmail dot com> <20150707162858 dot GR13549 at spoyarek dot pnq dot redhat dot com> <CA+6hz4omaZ2wjwCS1cKOXs27=p0oijUjtP9-8PVbyuDimQDtow at mail dot gmail dot com> <559CE58A dot 90706 at redhat dot com>
"Carlos O'Donell" <carlos@redhat.com> writes:
> diff --git a/Makefile b/Makefile
> index 658ccfa..c88b2e5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -262,7 +262,7 @@ endif
>
> $(objpfx)check-local-headers.out: scripts/check-local-headers.sh
> AWK='$(AWK)' scripts/check-local-headers.sh \
> - "$(includedir)" "$(objpfx)" > $@; \
> + "$(includedir)" "$(objpfx)" < /dev/null > $@; \
> $(evaluate-test)
This isn't the only problem with check-local-headers. It should really
make sure all *.dt files have been converted to *.d files first.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."