This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 13/14] [x86_64] Vector math functions (sincos and tests)


On Fri, 19 Jun 2015, Andrew Senkevich wrote:

> Proposal is fix it so:
> 
> diff --git a/bits/libm-simd-decl-stubs.h b/bits/libm-simd-decl-stubs.h
> index ec1fa69..6d0558a 100644
> --- a/bits/libm-simd-decl-stubs.h
> +++ b/bits/libm-simd-decl-stubs.h
> @@ -45,6 +45,10 @@
>  #define __DECL_SIMD_sincosf
>  #define __DECL_SIMD_sincosl
> 
> +/* This is needed because of definition of sincos
> +   in sysdeps/ieee754/ldbl-opt/s_sin.c.  */
> +# define __DECL_SIMD_sincos_disable
> +

It would seem better to me to put this in the .c file that needs it, 
rather than in an installed header - it should only be relevant when 
building glibc, not when using the installed library.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]