This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 13/14] [x86_64] Vector math functions (sincos and tests)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, <sjmunroe at us dot ibm dot com>, <tuliom at linux dot vnet dot ibm dot com>, Anton Blanchard <anton at samba dot org>
- Date: Fri, 19 Jun 2015 11:25:44 +0000
- Subject: Re: [PATCH 13/14] [x86_64] Vector math functions (sincos and tests)
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3t4CRSW2pRELmJMU5bE0eoYfUx7pO2-iLqLiGvgE79d_A at mail dot gmail dot com> <20150619075546 dot 4284b164 at kryten> <CAMXFM3srg-a6+MJQ7btm-wMVUBazEif53EyHbnpv=+RCgAocvA at mail dot gmail dot com>
On Fri, 19 Jun 2015, Andrew Senkevich wrote:
> Proposal is fix it so:
>
> diff --git a/bits/libm-simd-decl-stubs.h b/bits/libm-simd-decl-stubs.h
> index ec1fa69..6d0558a 100644
> --- a/bits/libm-simd-decl-stubs.h
> +++ b/bits/libm-simd-decl-stubs.h
> @@ -45,6 +45,10 @@
> #define __DECL_SIMD_sincosf
> #define __DECL_SIMD_sincosl
>
> +/* This is needed because of definition of sincos
> + in sysdeps/ieee754/ldbl-opt/s_sin.c. */
> +# define __DECL_SIMD_sincos_disable
> +
It would seem better to me to put this in the .c file that needs it,
rather than in an installed header - it should only be relevant when
building glibc, not when using the installed library.
--
Joseph S. Myers
joseph@codesourcery.com