This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix include/bits/ipc.h for header conformance tests
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 18 Jun 2015 15:34:34 -0700 (PDT)
- Subject: Re: Fix include/bits/ipc.h for header conformance tests
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1506182030060 dot 13372 at digraph dot polyomino dot org dot uk>
None of that stuff belongs there at all. The IPCOP_* macros are already in
sysdeps/unix/sysv/linux/ipc_priv.h and that's where they belong.
__syscall_ipc does not seem to actually exist, so its declaration is dead.
So I think the right fix should be just to remove include/bits/ipc.h
altogether. Off hand I suspect that will just work as is. If it breaks
anything, it should be nothing more than a missing #include <ipc_priv.h>.
i?86 should be a sufficient build to test that change.
sysdeps/unix/sysv/linux/powerpc/bits/ipc.h (the installed header) also
declares __ipc (which does not exist) and defines the IPCOP_* macros.
Those should not be there either. Those probably won't cause any
conformtest failures on powerpc since the macros are in #ifdef __USE_GNU
and the declaration is an __ name. But they should go.
Thanks,
Roland