This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] x86-64: Remove plt bypassing of ifuncs.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Ondřej Bílka <neleai at seznam dot cz>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 8 Jun 2015 20:57:39 +0000
- Subject: Re: [PATCH] x86-64: Remove plt bypassing of ifuncs.
- Authentication-results: sourceware.org; auth=none
- References: <20150608181414 dot GA32139 at domone>
On Mon, 8 Jun 2015, OndÅej BÃlka wrote:
> Here I removed bypassing from x64 functions, question is how disable
> generically bypassing in ifuncs, for normal functions plt bypassing has
> benefits but now its something that gcc should do, see recent noplt
> proposal on gcc list.
>
> Here I did removal for x64 and guarded hidden_proto with !defined
> __x86_64__, I don't know if its better to let other maintainers do same
> or come with generic solution.
I think it should work to make the hidden alias be an alias for the IFUNC
(in the multi-arch case - obviously with --disable-multi-arch it needs to
continue to exist as an alias for the non-IFUNC, and it's desirable to run
tests for both cases for any such patch). That way you shouldn't need to
change include/string.h at all. The hidden aliases will get PLT entries,
but such entries don't cause the localplt test to fail and there are a few
already anyway.
--
Joseph S. Myers
joseph@codesourcery.com