This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Remove socket.S implementation
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 22 May 2015 18:03:37 -0300
- Subject: Re: [PATCH v2] Remove socket.S implementation
- Authentication-results: sourceware.org; auth=none
- References: <555E3876 dot 3010805 at linaro dot org> <alpine dot DEB dot 2 dot 10 dot 1505212016040 dot 24623 at digraph dot polyomino dot org dot uk> <555E4A92 dot 30200 at linaro dot org> <alpine dot DEB dot 2 dot 10 dot 1505212115190 dot 24623 at digraph dot polyomino dot org dot uk>
On 21-05-2015 18:15, Joseph Myers wrote:
> On Thu, 21 May 2015, Adhemerval Zanella wrote:
>
>> On 21-05-2015 17:17, Joseph Myers wrote:
>>> On Thu, 21 May 2015, Adhemerval Zanella wrote:
>>>
>>>> * v (check_may_shrink_heap):
>>>> Initialize val variable.
>>>
>>> I don't see how this relates to the rest of the patch; it seems like
>>> something that should be submitted separately with its own rationale.
>>>
>>
>> It does not and it should be on a different patch [1]. I will remove it
>> from this patch.
>>
>> Besides this and Richard's review, do you have any impeding issue about
>> this patch? Thanks for you review.
>
> I do not have other comments at this time.
>
I pushed with the removed 'malloc-sysdep.h' change and Richard's points.