This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Simplify handling of nameserver configuration in resolver


On Mon, May 11, 2015 at 11:23:54AM +0200, Andreas Schwab wrote:
> Much of the IPv6 support in resolv.conf is overly convoluted and hard to
> understand, proven by the fact that trying to fix something in the past
> has always (re-)introduced bugs in other corners.  This patch removes
> the use of the ext.nsmap member of struct __res_state and always uses
> an identity mapping betwen the nsaddr_list array and the ext.nsaddrs
> array.  The fact that a nameserver has an IPv6 address is signalled by
> setting nsaddr_list[].sin_family to zero.
> 
> This has been suceessfully tested for some time in openSUSE Factory.
> 
> Andreas.
> 
> 	[BZ #13028]
> 	[BZ #17053]
> 	* resolv/res_init.c (__res_vinit): Remove use of ext.nsmap member
> 	of struct __res_state.
> 	* resolv/res_send.c (__libc_res_nsend): Likewise.
> 	(get_nsaddr): New function.
> 	(res_ourserver_p, send_vc, reopen): Use it instead of accessing
> 	statp directly.

Thank you for doing this.  Looks good to me.

Siddhesh

Attachment: pgp2Ne29JPFnx.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]