This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add envz_remove to the libc manual
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: Florian Weimer <fweimer at redhat dot com>, <libc-alpha at sourceware dot org>
- Date: Tue, 19 May 2015 20:31:15 +0000
- Subject: Re: [PATCH] Add envz_remove to the libc manual
- Authentication-results: sourceware.org; auth=none
- References: <20150318082908 dot GH5023 at spoyarek dot pnq dot redhat dot com> <550A0D65 dot 3030206 at redhat dot com> <20150518111713 dot GF15498 at spoyarek dot pnq dot redhat dot com>
On Mon, 18 May 2015, Siddhesh Poyarekar wrote:
> On Thu, Mar 19, 2015 at 12:42:29AM +0100, Florian Weimer wrote:
> > The safety annotations are incorrect, see envz_add and argz_delete:
> >
> > @safety{@prelim{}@mtsafe{}@asunsafe{@ascuheap{}}@acunsafe{@acsmem{}}}
> > @c Calls envz_remove, which calls enz_entry and argz_delete, and then
> > @c argz_add or equivalent code that reallocs and appends name=value.
> >
> > @safety{@prelim{}@mtsafe{}@asunsafe{@ascuheap{}}@acunsafe{@acsmem{}}}
> > @c Calls free if no argument is left.
>
> Right, I'll push the following patch with the annotations fixed up.
>
> Siddhesh
>
> * manual/string.texi (Envz Functions): Add envz_remove.
The manual build / install now fails:
/bin/sh ./check-safety.sh intro.texi creature.texi errno.texi memory.texi
ctype.texi string.texi charset.texi locale.texi message.texi search.texi
pattern.texi io.texi stdio.texi llio.texi filesys.texi pipe.texi
socket.texi terminal.texi syslog.texi math.texi arith.texi time.texi
resource.texi setjmp.texi signal.texi startup.texi getopt.texi argp.texi
process.texi ipc.texi job.texi nss.texi nsswitch.texi users.texi
sysinfo.texi conf.texi crypt.texi debug.texi threads.texi probes.texi
lang.texi header.texi install.texi macros.texi maint.texi platform.texi
contrib.texi freemanuals.texi lgpl-2.1.texi fdl-1.3.texi
string.texi:2794:@safety{@prelim{}@mtsafe{}@asunsafe{@acsuheap{}}@acunsafe{@acsmem{}}}
grep: write error
string.texi:2794:@safety{@prelim{}@mtsafe{}@asunsafe{@acsuheap{}}@acunsafe{@acsmem{}}}
string.texi:2794:@safety{@prelim{}@mtsafe{}@asunsafe{@acsuheap{}}@acunsafe{@acsmem{}}}
make[2]: *** [/home/jsm28/nobackup/glibc/build-64/manual/stamp-summary]
Error 1
make[2]: Leaving directory `/home/jsm28/nobackup/glibc/libc/manual'
make[1]: *** [manual/subdir_install] Error 2
make[1]: Leaving directory `/home/jsm28/nobackup/glibc/libc'
make: *** [install] Error 2
--
Joseph S. Myers
joseph@codesourcery.com