This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Incomplete patch to fix build with top-of-tree GCC

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Joseph Myers <joseph at codesourcery dot com>, Steve Ellcey <sellcey at imgtec dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Fri, 15 May 2015 13:29:12 -0700
Subject: Re: Incomplete patch to fix build with top-of-tree GCC
Authentication-results: sourceware.org; auth=none
References: <1431708170 dot 16668 dot 8 dot camel at ubuntu-sellcey> <alpine dot DEB dot 2 dot 10 dot 1505151645070 dot 21212 at digraph dot polyomino dot org dot uk>

On 05/15/2015 09:47 AM, Joseph Myers wrote:

The first question is:*is*  it OK to ignore the warnings?

I looked just at the first hunk of the patch, and it appears to me thatit's not OK to ignore its warnings. The type punning in the first hunkappears to violate the C standard; although I don't know whether GCC isgenerating "incorrect" code as a result, instead of silencing thewarning how about fixing the code so that it doesn't have those funkycasts? Something like the attached (untested) patch, say.

Attachment: t.txt
Description: Text document

Follow-Ups:
- Re: Incomplete patch to fix build with top-of-tree GCC
  - From: Carlos O'Donell

References:
- Incomplete patch to fix build with top-of-tree GCC
  - From: Steve Ellcey
- Re: Incomplete patch to fix build with top-of-tree GCC
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]