This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ 14172] Add South Azerbaijani (azb) locale
- From: Marko Myllynen <myllynen at redhat dot com>
- To: libc-alpha at sourceware dot org, mjbmri at gmail dot com
- Date: Thu, 07 May 2015 11:24:40 +0300
- Subject: Re: [PATCH][BZ 14172] Add South Azerbaijani (azb) locale
- Authentication-results: sourceware.org; auth=none
- References: <554AF03A dot 2010601 at gmail dot com>
- Reply-to: myllynen at redhat dot com
Hi,
On 2015-05-07 07:55, Mjbmr wrote:
> Add South Azerbaijani (azb) locale
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=14172#c11
> https://www.ethnologue.com/language/azb
I don't know the language so I cannot comment on those aspects but in
general it looks pretty good with one major and few minor issues. The
major issue is that the locale does not compile, please see the Locales
wiki page for instructions how to test locales (looks like you need to
adjust the country codes and perhaps also introduce a new language code
definition in iso-639.def):
https://sourceware.org/glibc/wiki/Locales
Also see the manual page or other locales (like de_DE) for the format to
use (ie, plain strings / texts are very rarely used):
http://man7.org/linux/man-pages/man5/locale.5.html
Please add the week definition to LC_TIME section and fix the fr_IR typo.
Cheers,
--
Marko Myllynen