This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/4] i386: Remove fallocate, fallocate64, posix_fallocate, posix_fallocate64


On 04/24/2015 06:46 PM, Roland McGrath wrote:
>> +	* sysdeps/unix/sysv/linux/i386/Makefile (sysdep_routines) [misc]:
>> +	Remove call_fallocate.
>> +	(sysdep_routines) [io]: Add libc-do-syscall.
> 
> These should be written like:
> 
> 	[$(subdir) = misc] (sysdep_routines): ...

Thanks.  Other suggestions?

> Why isn't libc-do-syscall just in sysdep.S?

I suspect it's because it isn't widely used at present.

I think we can get rid of the assembly version of mmap/mmap64, then this
would change.

-- 
Florian Weimer / Red Hat Product Security


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]