This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/4] i386: Remove fallocate, fallocate64, posix_fallocate, posix_fallocate64
- From: Florian Weimer <fweimer at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha at sourceware dot org, Joseph Myers <joseph at codesourcery dot com>
- Date: Mon, 27 Apr 2015 20:16:14 +0200
- Subject: Re: [PATCH 2/4] i386: Remove fallocate, fallocate64, posix_fallocate, posix_fallocate64
- Authentication-results: sourceware.org; auth=none
- References: <20150424134512 dot 58DCE41F484D0 at oldenburg dot str dot redhat dot com> <20150424164624 dot C20052C3B22 at topped-with-meat dot com>
On 04/24/2015 06:46 PM, Roland McGrath wrote:
>> + * sysdeps/unix/sysv/linux/i386/Makefile (sysdep_routines) [misc]:
>> + Remove call_fallocate.
>> + (sysdep_routines) [io]: Add libc-do-syscall.
>
> These should be written like:
>
> [$(subdir) = misc] (sysdep_routines): ...
Thanks. Other suggestions?
> Why isn't libc-do-syscall just in sysdep.S?
I suspect it's because it isn't widely used at present.
I think we can get rid of the assembly version of mmap/mmap64, then this
would change.
--
Florian Weimer / Red Hat Product Security