This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH COMMITTED] test-skeleton: Support temporary files without memory leaks [BZ#18333]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 27 Apr 2015 19:43:24 +0200
- Subject: Re: [PATCH COMMITTED] test-skeleton: Support temporary files without memory leaks [BZ#18333]
- Authentication-results: sourceware.org; auth=none
- References: <54E24689 dot 4010108 at redhat dot com> <54E24EEF dot 6090503 at cs dot ucla dot edu> <54E2516E dot 8050100 at redhat dot com> <54E27473 dot 6030407 at cs dot ucla dot edu> <54E46D70 dot 7000601 at redhat dot com> <553A6311 dot 70407 at redhat dot com> <CAMe9rOqmVSybC4ZzYFg7W8jWt7YPtO3m2i3wTAxSnHbqjE_x4A at mail dot gmail dot com> <553E46C7 dot 9000608 at redhat dot com> <CAMe9rOpdNDsXxcwRcpi2MxuoRhA0H85HHWrPXbUAv=3sv2BTzA at mail dot gmail dot com>
On 04/27/2015 07:01 PM, H.J. Lu wrote:
> On Mon, Apr 27, 2015 at 7:25 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 04/26/2015 03:50 PM, H.J. Lu wrote:
>>> On Fri, Apr 24, 2015 at 8:36 AM, Florian Weimer <fweimer@redhat.com> wrote:
>>>> On 02/18/2015 11:46 AM, Florian Weimer wrote:
>>>>> On 02/16/2015 11:51 PM, Paul Eggert wrote:
>>>>>> Florian Weimer wrote:
>>>>>>> So I'm not sure what to do here. Get rid of the alloca? That's going
>>>>>>> to be more difficult to review.
>>>>>>
>>>>>> I haven't read the code carefully, but if the only reason for the alloca
>>>>>> is to have a temporary string that one can munge by storing '\0' bytes
>>>>>> at strategic locations, then I presume that one could rewrite the code
>>>>>> to avoid the need to make a temporary copy,
>>>>>
>>>>> Indeed. I introduced __tzstring_len to avoid the need for the copy, and
>>>>> broke down __tzset_parse_tz into several smaller functions. Hopefully,
>>>>> the control flow is more transparent.
>>>>
>>>> I've committed this now, with a few whitespace fixes.
>>>>
>>>
>>> This caused:
>>>
>>> https://sourceware.org/bugzilla/show_bug.cgi?id=18333
>>
>> Fixed thusly. I didn't see the crash in my original testing.
>
> The bug is exposed by x32 with
>
> if (sizeof (time_t) == 8 && trans_width == 8)
> {
>
> I am testing this patch and will check it in after testing on x32.
Thanks for taking care of this issue.
--
Florian Weimer / Red Hat Product Security