This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use correct signedness in wcsncmp.
- From: Andreas Schwab <schwab at suse dot de>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 07 Apr 2015 18:10:54 +0200
- Subject: Re: [PATCH] Use correct signedness in wcsncmp.
- Authentication-results: sourceware.org; auth=none
- References: <mf0dja$acn$1 at ger dot gmane dot org> <alpine dot DEB dot 2 dot 10 dot 1504021735250 dot 408 at digraph dot polyomino dot org dot uk> <mg06ld$ods$1 at ger dot gmane dot org> <mvmzj6kfek0 dot fsf at hawking dot suse dot de> <mg0rcq$13o$1 at ger dot gmane dot org>
Stefan Liebler <stli@linux.vnet.ibm.com> writes:
> 2015-04-07 Stefan Liebler <stli@linux.vnet.ibm.com>
>
> * wcsmbs/wcsncmp.c (wcsncmp): Compare as wchar_t, not wint_t.
> Use signed comparision instead of substraction to avoid
> overflow bug.
> * localedata/tests-mbwc/tst_wcsncmp.c (tst_wcsncmp):
> Take the sign of ret.
> * localedata/tests-mbwc/dat_wcsncmp.c (tst_wcsncmp_loc):
> Do not expect precise return values. Only the sign matters.
> * wcsmbs/Makefile (strop-tests): Add wcsncmp.
> * wcsmbs/test-wcsncmp.c: New File.
> * string/test-strncmp.c: Add wcsncmp support.
Ok, thanks.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."