Re: [PATCH] Use correct signedness in wcsncmp.

[Stefan Liebler <stli at linux dot vnet dot ibm dot com>]

Hi,

On 04/02/2015 07:36 PM, Joseph Myers wrote:> Patches for bugs 
user-visible in a release should have a bug filed in
> Bugzilla if not already there, and [BZ #N] in the ChangeLog entry.
>

created a bug https://sourceware.org/bugzilla/show_bug.cgi?id=18206
and resend the unchanged patch with the bug added to the Changelog.

Ok to commit?

Bye Stefan

---
2015-04-07  Stefan Liebler  <stli@linux.vnet.ibm.com>

	[BZ #18206]
	* wcsmbs/wcsncmp.c (wcsncmp): Compare as wchar_t, not wint_t.
	  Use signed comparision instead of substraction to avoid
	  overflow bug.
	* localedata/tests-mbwc/tst_wcsncmp.c (tst_wcsncmp):
	  Take the sign of ret.
	* localedata/tests-mbwc/dat_wcsncmp.c (tst_wcsncmp_loc):
	  Do not expect precise return values. Only the sign matters.
	* wcsmbs/Makefile (strop-tests): Add wcsncmp.
	* wcsmbs/test-wcsncmp.c: New File.
	* string/test-strncmp.c: Add wcsncmp support.

Attachment: wcsncmp_26032015
Description: Text document