This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC PATCH 2/3] ARM64: ILP32: use __fsword_t in generic/bits/statfs.h
- From: Chris Metcalf <cmetcalf at ezchip dot com>
- To: "Zhang Jian(Bamvor)" <bamvor dot zhangjian at huawei dot com>, <libc-alpha at sourceware dot org>
- Cc: <apinski at cavium dot com>, <yangyingliang at huawei dot com>, <bintian dot wang at huawei dot com>, <dingtianhong at huawei dot com>
- Date: Thu, 19 Mar 2015 12:40:06 -0400
- Subject: Re: [RFC PATCH 2/3] ARM64: ILP32: use __fsword_t in generic/bits/statfs.h
- Authentication-results: sourceware.org; auth=none
- Authentication-results: huawei.com; dkim=none (message not signed) header.d=none;
- References: <1426674611-26427-1-git-send-email-bamvor dot zhangjian at huawei dot com> <1426674611-26427-3-git-send-email-bamvor dot zhangjian at huawei dot com>
On 03/18/2015 06:30 AM, Zhang Jian(Bamvor) wrote:
From: Yang Yingliang<yangyingliang@huawei.com>
Use __fsword_t to make size of struct statfs equal in userspace and kernel.
Signed-off-by: Yang Yingliang<yangyingliang@huawei.com>
---
sysdeps/unix/sysv/linux/generic/bits/statfs.h | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
I don't object to this patch as a cleanup (to match the types used in
the base Linux statfs.h), but can you tell me why this makes a
difference to you? On what asm-generic platform does __SWORD_TYPE !=
__fsword_t ? My earlier analysis a few minutes ago suggested that was
true only for alpha and x32, neither of which use the linux/generic code
in glibc.
--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com