This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC] Pretty printers for NPTL lock types
- From: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: libc-alpha at sourceware dot org, "Carlos O'Donell" <carlos at redhat dot com>, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>, Torvald Riegel <triegel at redhat dot com>
- Date: Wed, 11 Mar 2015 14:27:34 -0300
- Subject: Re: [RFC] Pretty printers for NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <CAOKbPbbVud=gru917mXYfnOnQ9nCCY1vR4fvyU8JpRVzaGe5bw at mail dot gmail dot com> <87oanzjy1n dot fsf at tromey dot com>
On Wed, Mar 11, 2015 at 1:31 PM, Tom Tromey <tom@tromey.com> wrote:
>>>>>> "Martin" == Martin Galvan <martin.galvan@tallertechnologies.com> writes:
>
> Martin> if self.lock == PTHREAD_MUTEX_UNLOCKED:
> Martin> print("* Status: Unlocked")
> Martin> else: # Mutex is locked
> Martin> if self.lock & FUTEX_WAITERS:
> Martin> print("* Status: Locked, possibly with waiters")
> Martin> else:
> Martin> print("* Status: Locked, no waiters")
>
> Despite their name, gdb pretty-printers shouldn't actually print
> anything. Really they are value-transformers and should either return a
> string value (for scalar-like objects) or an iterable of some kind (for
> aggregate objects).
My mistake, I thought the printers themselves were supposed to do the
actual printing. I'll refactor them accordingly. Thanks for the
feedback!