This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix failure to cleanup input-only stream buffers in preparation for BZ#16734 fix
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Sun, 08 Mar 2015 15:55:57 -0400
- Subject: Re: [patch] Fix failure to cleanup input-only stream buffers in preparation for BZ#16734 fix
- Authentication-results: sourceware.org; auth=none
- References: <CALoOobNy2mS=YFF63Hjz_+ewDPtjRa+Jyo_tofUM+vVkrS3bYA at mail dot gmail dot com> <54FC9929 dot 20708 at redhat dot com> <CALoOobPW2eSdY9B1EBT9se5COKkfprwBQMqqv2ZVvgSH0DNUew at mail dot gmail dot com>
On 03/08/2015 02:57 PM, Paul Pluzhnikov wrote:
> On Sun, Mar 8, 2015 at 11:47 AM, Carlos O'Donell <carlos@redhat.com> wrote:
>
>> Please still consider adding a test case for this specific
>> failure.
>
> Before the mmap->malloc switch, this failure manifests in missing
> munmap, but mmap/munmap from stdio is not interposable, and I am not
> sure there *is* a way to write a test for this.
Yes, you won't be able to test that.
> After the switch, sure: I can add a specific read-only fopen test.
Exactly.
Cheers,
Carlos.