This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use 1U everywhere in elf/elf.h.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Andreas Schwab <schwab at linux-m68k dot org>
- Date: Fri, 6 Mar 2015 09:26:51 -0800
- Subject: Re: [PATCH] Use 1U everywhere in elf/elf.h.
- Authentication-results: sourceware.org; auth=none
- References: <54F9E0CE dot 8070303 at redhat dot com>
On Fri, Mar 6, 2015 at 9:15 AM, Carlos O'Donell <carlos@redhat.com> wrote:
> All the bits should be unsigned int in elf/elf.h since
> otherwise you can get a warning for using SHF_EXCLUDE
> in certain situations.
>
> See:
> https://lists.fedorahosted.org/pipermail/elfutils-devel/2015-January/004576.html
>
> I just made them all use 1U for consistency.
>
> No regressions on x86_64.
>
> OK to commit?
>
> Cheers,
> Carlos.
>
> 2015-03-06 Carlos O'Donell <carlos@redhat.com>
>
> * elf.h: Use 1U everywhere.
>
LGTM.
--
H.J.