This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: Fix inline feraiseexcept, feclearexcept macros
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 03 Mar 2015 12:02:16 -0300
- Subject: Re: [PATCH] powerpc: Fix inline feraiseexcept, feclearexcept macros
- Authentication-results: sourceware.org; auth=none
- References: <54C2C558 dot 2050304 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1501240219420 dot 15542 at digraph dot polyomino dot org dot uk> <54C6449B dot 60609 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1501261804490 dot 28603 at digraph dot polyomino dot org dot uk> <54C7DC43 dot 7040500 at linux dot vnet dot ibm dot com> <54D8B4F9 dot 1040802 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1502112152070 dot 19244 at digraph dot polyomino dot org dot uk> <54EB2D9B dot 20404 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1502241736050 dot 5398 at digraph dot polyomino dot org dot uk>
On 24-02-2015 14:37, Joseph Myers wrote:
> On Mon, 23 Feb 2015, Adhemerval Zanella wrote:
>
>> +static void
>> +test_fesetround (void)
>> +{
>> +#if defined FE_TONEAREST && defined FE_TOWARDZERO
>> + int res;
>> +
>> + printf ("Tests for fesetround\n");
>> +
>> + res = fesetround ((int) FE_TOWARDZERO);
>> + if (res != 0)
>> + {
>> + printf ("fesetround (FE_TOWARDZERO) failed: %d\n", res);
>> + ++count_errors;
>> + }
> That fesetround fails should not itself cause the test to fail. But it
> should either succeed for both int and double versions of the same
> argument value, or fail for both.
>
Right, I have pushed the patch with this change. Thanks for the review!