This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: search locale archive again after alias expansion

On Feb 27, 2015, "Carlos O'Donell" <> wrote:

> That is ~9 lines of changes vs. the original ~22 lines of change.
Yeah, it is smaller, but it still covers a larger code area and thus
*more* lines of context, that will make patches in this area just as
hard, if not harder, to apply cleanly.  Plus, by not moving the
declaration down and changing the type of a variable, patches that apply
to the now-const area and introduce further references to loc_name might
still seem to apply with minor adjustments, even though they might
require further adjustments to account for the type change.

Anyway, if you really feel like playing against your stated goal of
making patches to this area easier to apply before and after (which I
DID take into account when deciding how to make the change to begin
with, mind you, because I share that concern), I won't stand in the way.
The difference is only one or two lines in the surface area anyway, so
go ahead with whatever you think is best.

Alexandre Oliva, freedom fighter
You must be the change you wish to see in the world. -- Gandhi
Be Free! --   FSF Latin America board member
Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]