This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix BZ #17916 fopen unbounded stack usage for ccs= modes

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: Florian Weimer <fw at deneb dot enyo dot de>, GLIBC Devel <libc-alpha at sourceware dot org>
Date: Mon, 23 Feb 2015 21:00:10 -0800
Subject: Re: [patch] Fix BZ #17916 fopen unbounded stack usage for ccs= modes
Authentication-results: sourceware.org; auth=none
References: <CALoOobPBCpZwMyF5F_4XzNJKKi64xMGtWgBXO_iDU_HpZ6+V9g at mail dot gmail dot com> <874mqdbr1w dot fsf at mid dot deneb dot enyo dot de> <CALoOobMKYAvdj63=7JKyQTPZHx_6c_0RVTxXjcLk-_wyFYWryg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1502231632100 dot 7064 at digraph dot polyomino dot org dot uk>

On Mon, Feb 23, 2015 at 8:33 AM, Joseph Myers <joseph@codesourcery.com> wrote:

> Typically such tests use setrlimit to set a stack limit lower than the
> amount of stack space the code used before the fix.

Thanks. I've updated the test and verified that it fails with stack
overflow if I revert the fix.

On Mon, Feb 23, 2015 at 5:47 AM, Florian Weimer <fweimer@redhat.com> wrote:

> I think you have to call _IO_file_close_it (fp) here, otherwise there's
> a resource leak.

Thanks. Fixed.

2015-02-22  Paul Pluzhnikov  <ppluzhnikov@google.com>

	    [BZ #17916]
	    * libio/fileops.c (_IO_new_file_fopen): Limit stack use
	    * libio/tst-fopenloc.c (do_test, do_bz17916): Add a large ccs= test

-- 
Paul Pluzhnikov

Attachment: bz17916.patch3.txt
Description: Text document

Follow-Ups:
- Re: [patch] Fix BZ #17916 fopen unbounded stack usage for ccs= modes
  - From: Florian Weimer
- Re: [patch] Fix BZ #17916 fopen unbounded stack usage for ccs= modes
  - From: Roland McGrath

References:
- [patch] Fix BZ #17916 fopen unbounded stack usage for ccs= modes
  - From: Paul Pluzhnikov
- Re: [patch] Fix BZ #17916 fopen unbounded stack usage for ccs= modes
  - From: Florian Weimer
- Re: [patch] Fix BZ #17916 fopen unbounded stack usage for ccs= modes
  - From: Paul Pluzhnikov
- Re: [patch] Fix BZ #17916 fopen unbounded stack usage for ccs= modes
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]