This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix BZ #17916 fopen unbounded stack usage for ccs= modes


On 02/23/2015 12:31 AM, Paul Pluzhnikov wrote:
> +	  if (ccs == NULL)
> +	    return NULL;

I think you have to call _IO_file_close_it (fp) here, otherwise there's
a resource leak.

Test case change is okay, this is how we usually test for stack overflow.

-- 
Florian Weimer / Red Hat Product Security


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]