This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [BZ 17588 13064] Update UTF-8 charmap and width to Unicode 7.0.0


On 18 Feb 2015 21:23, Alexandre Oliva wrote:
> --- a/localedata/unicode-gen/ctype_compatibility.py
> +++ b/localedata/unicode-gen/ctype_compatibility.py
>
> -# Copyright (C) 2014 Free Software Foundation, Inc.
> +# Copyright (C) 2014, 2015 Free Software Foundation, Inc.

should be a date range (2014-2015)

> +# Auxiliary tables for Hangul syllable names, see the Unicode 3.0 book,
> +# sections 3.11 and 4.4.
> +
> +jamo_initial_short_name = [
> +    'G', 'GG', 'N', 'D', 'DD', 'R', 'M', 'B', 'BB', 'S', 'SS', '', 'J', 'JJ',
> +    'C', 'K', 'T', 'P', 'H'
> +]

module level constants should really be in CAPS.  and use a tuple to make it 
const.
-mike

Attachment: signature.asc
Description: Digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]