This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH 1/1 V2] manual/time.texi: correct the zoneinfo path
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: J William Piggott <elseifthen at gmx dot com>, libc-alpha at sourceware dot org, Paul Eggert <eggert at cs dot ucla dot edu>
- Date: Fri, 13 Feb 2015 20:47:18 -0500
- Subject: Re: [PATCH 1/1 V2] manual/time.texi: correct the zoneinfo path
- Authentication-results: sourceware.org; auth=none
- References: <54B989EA dot 3080307 at gmx dot com> <54CED496 dot 7090905 at gmx dot com> <54DD6E60 dot 1090101 at redhat dot com> <54DE70D9 dot 40203 at gmx dot com> <54DE82D8 dot 4020601 at redhat dot com> <20150213231607 dot 84B932C3C27 at topped-with-meat dot com>
On 02/13/2015 06:16 PM, Roland McGrath wrote:
>> To be honest, as a patch. I'm going to change the contribution checklist.
> A consensus of one?
Sorry, my intent was to simply start a new discussion on the topic.
>> As a patch it allows me to use patchwork to pull down the patch, git am,
>> and then let my merge driver fix it up or fixup manually.
> The main reason it has always been policy not to include ChangeLog diffs in
> a patch is that the context (i.e. top few lines of the file) always changes
> and so the patch fails to apply. If it does happen to apply because of
> successful context matching, that puts the new log entry someplace other
> than at the top of the line, which is not allowed.
The mean reason I want everything in the patch is so that I can do:
pwclient get XXX
patch -1 < foo.patch
git am foo.patch
Then I fixup ChangeLog quickly.
Alternatively I would have to cut and paste from foo.patch to
This discussion however is going to degenerate quickly into "Why
do we need ChangeLogs" and that's not a useful place to go.
I will instead take this time to look over again how to do ChangeLog
auto-generation from commit meta-data, to solve this problem more easily.